If you use git and understand that VSC's source control stuff is just a thin wrapper around git, you should understand what "discard all changes" means

[–] JackbyDev@programming.dev 7 points 1 day ago* (last edited 1 day ago) (1 children)

"discard" is not a git operation. Reset and restore are, but those weren't the words used.

[–] zalgotext@sh.itjust.works -1 points 1 day ago (1 children)

I'm not claiming that "discard" is a git action. I'm claiming a git user should understand what's meant by the phrase "discard changes". Run git status in a repo that has changes in the working directory. In the resulting output, there's a message:

Changes not staged for commit:
    (use "git add <file>..." to update what will be committed) 
    (use "git restore <file>..." to discard changes in working directory)
        ...

The phrase "discard changes" is used consistently in git's output.

[–] JackbyDev@programming.dev 3 points 1 day ago (1 children)

Read this comment from the linked bug. https://github.com/microsoft/vscode/issues/32459#issuecomment-322160461

[–] zalgotext@sh.itjust.works 3 points 1 day ago

Ok that's understandable, I didn't realize VSCode used to delete untracked files as well as a result of clicking through that dialogue.

[–] mindbleach@sh.itjust.works 0 points 1 day ago

Broken stair apologism.

[–] bitwolf@sh.itjust.works -4 points 1 day ago* (last edited 1 day ago) (1 children)

I just tried right now to get the exact message.

Are you sure you want to DELETE foo?
This is IRREVERSIBLE!
This file will be FOREVER LOST if you proceed.

The confirmation button even says Delete File...

User error.

[–] jas0n@lemmy.world 16 points 1 day ago (1 children)

This issue was from 2017

[–] bitwolf@sh.itjust.works 9 points 1 day ago

Ah looking at issue 32459 it was addressed shortly after.

You're right that it did originally say "Discard".